Skip to content

Auto approve patch changes to the repo #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2025

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Aug 18, 2025

Asana Task/Github Issue:

Description

Auto approves and merges PRs created by dependabot for patches after tests run.
We ensure that all status checks must pass for these.

Context is repeated this:
image

I doubt we'd ever catch supply chain style attacks either easily and my understanding is dependabot does some of this automatically, we also do have code check analysis too.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@jonathanKingston jonathanKingston marked this pull request as ready for review August 18, 2025 16:33
@jonathanKingston jonathanKingston requested a review from a team as a code owner August 18, 2025 16:33
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit fcf97f8
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68a48b4d080c010008bbb0b5
😎 Deploy Preview https://deploy-preview-1904--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Aug 18, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Aug 18, 2025

[Beta] Generated file diff

Time updated: Tue, 19 Aug 2025 14:35:00 GMT

@jonathanKingston
Copy link
Contributor Author

Disabling auto-merge as @shakyShane said he wanted to exclude a few high risk front-end related libs too (at least initially without further tests).

@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit 61255ca Aug 19, 2025
18 checks passed
@jonathanKingston jonathanKingston deleted the jkt/approve-patch-changes branch August 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants